Page MenuHomePhabricator

Redirect `/source/x` (no slash) to `/source/x/` (canonical) when viewer is logged out and "x" is public
ClosedPublic

Authored by epriestley on Dec 20 2016, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 27, 11:11 AM
Unknown Object (File)
Thu, Jun 26, 4:20 AM
Unknown Object (File)
May 13 2025, 10:24 PM
Unknown Object (File)
May 13 2025, 10:22 PM
Unknown Object (File)
May 13 2025, 6:45 PM
Unknown Object (File)
May 9 2025, 9:18 AM
Unknown Object (File)
May 6 2025, 5:17 PM
Unknown Object (File)
Apr 5 2025, 8:34 AM
Subscribers
None

Details

Summary

Fixes T12035. Normally, the "abc" -> "abc/" redirect is handled automatically when "abc" hits a 404.

However, in this case, "source/x" does not 404. We route this to a valid controller because some VCS requests omit the slashes, then manually perform the redirect if we aren't serving a VCS request.

Allow this controller to serve public resources so we can serve the redirect to logged-out users instead of prompting them to login so they can be redirected.

Test Plan

Visited /source/x as a logged-out user, where x is a public repository.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable