Page MenuHomePhabricator

Redirect `/source/x` (no slash) to `/source/x/` (canonical) when viewer is logged out and "x" is public
ClosedPublic

Authored by epriestley on Dec 20 2016, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 2:03 PM
Unknown Object (File)
Fri, Dec 6, 3:49 PM
Unknown Object (File)
Sat, Nov 30, 7:16 PM
Unknown Object (File)
Tue, Nov 19, 12:14 PM
Unknown Object (File)
Oct 25 2024, 9:20 AM
Unknown Object (File)
Oct 19 2024, 5:34 AM
Unknown Object (File)
Oct 16 2024, 2:30 AM
Unknown Object (File)
Oct 13 2024, 4:14 PM
Subscribers
None

Details

Summary

Fixes T12035. Normally, the "abc" -> "abc/" redirect is handled automatically when "abc" hits a 404.

However, in this case, "source/x" does not 404. We route this to a valid controller because some VCS requests omit the slashes, then manually perform the redirect if we aren't serving a VCS request.

Allow this controller to serve public resources so we can serve the redirect to logged-out users instead of prompting them to login so they can be redirected.

Test Plan

Visited /source/x as a logged-out user, where x is a public repository.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable