Page MenuHomePhabricator
Differential D17090

Add Ngram support to Dashboards / Panels
ClosedPublic
Actions

Authored by chad on Dec 16 2016, 6:39 PM.
Tags
None
Referenced Files
F14299784: D17090.id41105.diff
Tue, Dec 17, 4:30 PM
Unknown Object (File)
Sat, Dec 14, 9:10 AM
Unknown Object (File)
Fri, Dec 6, 12:19 PM
Unknown Object (File)
Fri, Dec 6, 11:44 AM
Unknown Object (File)
Tue, Dec 3, 9:16 AM
Unknown Object (File)
Mon, Nov 18, 10:15 PM
Unknown Object (File)
Nov 11 2024, 6:18 AM
Unknown Object (File)
Nov 5 2024, 4:51 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPc6bdd2c56bab: Add Ngram support to Dashboards / Panels
Summary

Build ngram indexs, adds search by name capability.

Test Plan

Search for a dashboard by partial name, search for a panel by partial name.

Diff Detail

Repository
rP Phabricator
Branch
ngrams-dashboards (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14994
Build 19661: Run Core Tests
Build 19660: arc lint + arc unit

Event Timeline

chad created this revision.Dec 16 2016, 6:39 PM
Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2016, 6:39 PM
epriestley accepted this revision.Dec 16 2016, 8:06 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
24

"badges" should be "dashboards".

This revision is now accepted and ready to land.Dec 16 2016, 8:06 PM
chad added inline comments.Dec 16 2016, 8:06 PM
src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php
54

this one's ok though? amirite?

chad added a comment.Dec 16 2016, 8:07 PM

daftpunk

Closed by commit rPc6bdd2c56bab: Add Ngram support to Dashboards / Panels (authored by chad, committed by chad). · Explain WhyDec 16 2016, 8:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley added inline comments.Dec 16 2016, 8:09 PM
src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php
54

ACTUALLY IT LOOKS LIKE IT IS INDENTED TOO MUCH

frowncat

epriestley added a comment.Dec 16 2016, 8:13 PM

I am also shocked that you apparently encountered 0 fatals/exceptions/bugs while creating and landing this diff instead of the expected 50+.

Revision Contents
Changeset List

Diff 41105

View Options

resources/sql/autopatches/20161216.dashboard.ngram.01.sql

Loading...
View Options

resources/sql/autopatches/20161216.dashboard.ngram.02.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardNgrams.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanelNgrams.php

Loading...
Phabricator · Built by Phacility