Page MenuHomePhabricator
Differential D17090

Add Ngram support to Dashboards / Panels
ClosedPublic
Actions

Authored by chad on Dec 16 2016, 6:39 PM.
Tags
None
Referenced Files
F13080868: D17090.id41107.diff
Wed, Apr 24, 10:50 AM
Unknown Object (File)
Fri, Apr 19, 5:57 PM
Unknown Object (File)
Fri, Apr 12, 10:23 PM
Unknown Object (File)
Thu, Apr 11, 8:23 AM
Unknown Object (File)
Tue, Apr 9, 7:39 PM
Unknown Object (File)
Sun, Mar 31, 9:53 AM
Unknown Object (File)
Tue, Mar 26, 7:34 PM
Unknown Object (File)
Tue, Mar 26, 7:34 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPc6bdd2c56bab: Add Ngram support to Dashboards / Panels
Summary

Build ngram indexs, adds search by name capability.

Test Plan

Search for a dashboard by partial name, search for a panel by partial name.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Dec 16 2016, 6:39 PM
Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2016, 6:39 PM
epriestley accepted this revision.Dec 16 2016, 8:06 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
24

"badges" should be "dashboards".

This revision is now accepted and ready to land.Dec 16 2016, 8:06 PM
chad added inline comments.Dec 16 2016, 8:06 PM
src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php
54

this one's ok though? amirite?

chad added a comment.Dec 16 2016, 8:07 PM

daftpunk

Closed by commit rPc6bdd2c56bab: Add Ngram support to Dashboards / Panels (authored by chad, committed by chad). · Explain WhyDec 16 2016, 8:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley added inline comments.Dec 16 2016, 8:09 PM
src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php
54

ACTUALLY IT LOOKS LIKE IT IS INDENTED TOO MUCH

frowncat

epriestley added a comment.Dec 16 2016, 8:13 PM

I am also shocked that you apparently encountered 0 fatals/exceptions/bugs while creating and landing this diff instead of the expected 50+.

Revision Contents
Changeset List

Diff 41107

View Options

resources/sql/autopatches/20161216.dashboard.ngram.01.sql

Loading...
View Options

resources/sql/autopatches/20161216.dashboard.ngram.02.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardNgrams.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanelNgrams.php

Loading...
Phabricator · Built by Phacility