Page MenuHomePhabricator
Differential D17086

Simplify Differential "Reviewers" field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:49 PM.
Tags
None
Referenced Files
F15514184: D17086.id41078.diff
Fri, Apr 18, 1:00 AM
F15509544: D17086.id41078.diff
Wed, Apr 16, 1:42 PM
F15489478: D17086.id41102.diff
Fri, Apr 11, 9:21 AM
F15473317: D17086.diff
Sat, Apr 5, 8:59 PM
F15460786: D17086.id41102.diff
Tue, Apr 1, 2:12 AM
F15439236: D17086.id.diff
Mar 26 2025, 6:28 AM
F15438341: D17086.diff
Mar 26 2025, 12:14 AM
F15390460: D17086.id.diff
Mar 15 2025, 6:14 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP18debbfdb4f4: Simplify Differential "Reviewers" field
Summary

Ref T11114. Keep rendering and mail, toss the rest.

Test Plan

Edited and viewed reviewers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41078.Dec 16 2016, 5:49 PM
epriestley retitled this revision from to Simplify Differential "Reviewers" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:50 PM
Closed by commit rP18debbfdb4f4: Simplify Differential "Reviewers" field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
239 lines
storage/
3 lines
transactions/
storage/
15 lines

Diff 41102

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility