Page MenuHomePhabricator
Differential D17083

Remove Differential "Title" custom field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:32 PM.
Tags
None
Referenced Files
F15415901: D17083.diff
Thu, Mar 20, 8:19 AM
F15398420: D17083.id.diff
Mon, Mar 17, 12:05 AM
F15398417: D17083.diff
Mon, Mar 17, 12:05 AM
F15368262: D17083.id41075.diff
Wed, Mar 12, 1:15 AM
Unknown Object (File)
Mon, Mar 3, 8:04 PM
Unknown Object (File)
Feb 18 2025, 12:14 PM
Unknown Object (File)
Feb 11 2025, 8:16 PM
Unknown Object (File)
Feb 2 2025, 9:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP9e4c16c4c3ac: Remove Differential "Title" custom field
Summary

Ref T11114. Obsoleted by Modular Transactions + EditEngine + CommitMessageField + we just "hard code" the title of revisions into the page because we're craaazy.

Test Plan
  • Made an edit on stable.
  • Viewed the edit on this change, it still had the proper UI strings.
  • Edited/created/updated revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41075.Dec 16 2016, 5:32 PM
epriestley retitled this revision from to Remove Differential "Title" custom field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:49 PM
Closed by commit rP9e4c16c4c3ac: Remove Differential "Title" custom field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
1 line
customfield/
storage/
17 lines
transactions/
storage/
6 lines

Diff 41099

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTitleField.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
Phabricator · Built by Phacility