This is just some housekeeping - see note in D16287. Basically, "isTextMode" doesn't convey enough information.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rP8b7e99f68c97: Introduce ModularTransactionType::isRenderingTargetExternal
git grep isTextMode | grep -v Remarkup, and visit all callsites; There are 4 of them left.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Of the 4 remaining callsites, 3 are in this file (1 for actual rendering, and 2 for $viewer->renderHandle()->setAsText(), which we might want to someday extend to setTargetExternal too), and one is in DifferentialRevisionReviewersTransaction which is also doing rendering, but looks funny non-the-less (implode vs phutil_implode_html).
I've also grepped for getRenderingTarget, and it like all callsites really are concerned with rendering.