Page MenuHomePhabricator

Introduce ModularTransactionType::isRenderingTargetExternal
ClosedPublic

Authored by avivey on Dec 16 2016, 12:15 AM.
Tags
None
Referenced Files
F15420705: D17063.id41051.diff
Fri, Mar 21, 4:13 PM
F15409973: D17063.id41051.diff
Wed, Mar 19, 6:20 AM
F15409058: D17063.id41050.diff
Wed, Mar 19, 3:05 AM
F15408287: D17063.id.diff
Tue, Mar 18, 10:11 PM
F15400596: D17063.diff
Mon, Mar 17, 12:47 PM
F15398368: D17063.diff
Mon, Mar 17, 12:02 AM
F15383692: D17063.id41051.diff
Fri, Mar 14, 5:35 PM
F15375978: D17063.id.diff
Thu, Mar 13, 1:08 AM
Subscribers

Details

Summary

This is just some housekeeping - see note in D16287. Basically, "isTextMode" doesn't convey enough information.

Test Plan

git grep isTextMode | grep -v Remarkup, and visit all callsites; There are 4 of them left.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to Introduce ModularTransactionType::isRenderingTargetExternal.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.

Of the 4 remaining callsites, 3 are in this file (1 for actual rendering, and 2 for $viewer->renderHandle()->setAsText(), which we might want to someday extend to setTargetExternal too), and one is in DifferentialRevisionReviewersTransaction which is also doing rendering, but looks funny non-the-less (implode vs phutil_implode_html).

I've also grepped for getRenderingTarget, and it like all callsites really are concerned with rendering.

epriestley edited edge metadata.

The DifferentialRevisionReviewersTransaction one is maybe hopefully temporary-ish.

This revision is now accepted and ready to land.Dec 16 2016, 12:47 AM
This revision was automatically updated to reflect the committed changes.