Paths

Table of Contentst

Differential D17060

Probably (?) fix two very old project slug migrations
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 10:10 PM.

Tags

None

Referenced Files

	F13092336: D17060.diff
	Thu, Apr 25, 3:41 AM

	Unknown Object (File)
	Sat, Apr 20, 4:14 PM

	Unknown Object (File)
	Fri, Apr 19, 5:54 PM

	Unknown Object (File)
	Wed, Apr 17, 4:01 AM

	Unknown Object (File)
	Fri, Apr 12, 10:23 PM

	Unknown Object (File)
	Thu, Apr 4, 10:35 AM

	Unknown Object (File)
	Wed, Apr 3, 3:29 PM

	Unknown Object (File)
	Mon, Apr 1, 3:25 PM

Subscribers

None

Tokens

"Evil Spooky Haunted Tree" token, awarded by epriestley.

Details

Reviewers

avivey
chad

Maniphest Tasks

T12020: Broken migration: phabricator:20140521.projectslug.2.mig.php

Commits

rP3d8d98bd8deb: Probably (?) fix two very old project slug migrations

Summary

Fixes T12020. These callsites to getPhrictionSlug() were missed when that method was removed. They're very old (early 2014, late 2011).

Test Plan

These are tricky to test because the migrations are so ancient, but bin/storage upgrade --force --apply phabricator:20140521.projectslug.2.mig.php gave me plausible results.

The other migration is so ancient that it can't apply to a modern database so I'm just kind of winging that one. We probably have essentially no installs which will ever apply it again, though.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41034.Dec 14 2016, 10:10 PM

epriestley retitled this revision from to Probably (?) fix two very old project slug migrations.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: avivey, chad.

epriestley added a task: T12020: Broken migration: phabricator:20140521.projectslug.2.mig.php.

This can't really get any more broken, right?

This revision is now accepted and ready to land.Dec 14 2016, 10:12 PM

Well, it could destroy data instead of simply not working. But I think we're probably in the clear on this.

Closed by commit rP3d8d98bd8deb: Probably (?) fix two very old project slug migrations (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140521.projectslug.2.mig.php

13 lines

patches/

090.forceuniqueprojectnames.php

4 lines

Diff 41036

resources/sql/autopatches/20140521.projectslug.2.mig.php

Loading...

resources/sql/patches/090.forceuniqueprojectnames.php

Loading...