Page MenuHomePhabricator
Differential D17057

Reorganize phui-object-item CSS, add drag ui
ClosedPublic
Actions

Authored by chad on Dec 14 2016, 7:37 PM.
Tags
None
Referenced Files
F15454573: D17057.diff
Sat, Mar 29, 7:09 PM
F15441833: D17057.id.diff
Wed, Mar 26, 8:15 PM
F15428282: D17057.id41029.diff
Sun, Mar 23, 6:53 PM
F15419303: D17057.id.diff
Fri, Mar 21, 5:10 AM
F15398908: D17057.diff
Mon, Mar 17, 1:53 AM
F15398364: D17057.id41030.diff
Mon, Mar 17, 12:02 AM
F15398363: D17057.id41029.diff
Mon, Mar 17, 12:02 AM
F15398362: D17057.id.diff
Mon, Mar 17, 12:02 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPe077d2f7a79a: Reorganize phui-object-item CSS, add drag ui
Summary

Reorgaizes the CSS here a bit, by object list style, adds in a new drag ui class, which will be used in menu ordering.

Test Plan

Workboards, Home Apps.

pasted_file (686×1 px, 77 KB)

Diff Detail

Repository
rP Phabricator
Branch
new-drag-ui
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14917
Build 19542: Run Core Tests
Build 19541: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 41029.Dec 14 2016, 7:37 PM
chad retitled this revision from to Reorganize phui-object-item CSS, add drag ui.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 14 2016, 7:37 PM
chad edited the test plan for this revision. (Show Details)Dec 14 2016, 7:37 PM

also shorted the css class names to phui-oi instead of phui-object-item

epriestley accepted this revision.Dec 14 2016, 7:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 7:50 PM
Closed by commit rPe077d2f7a79a: Reorganize phui-object-item CSS, add drag ui (authored by chad, committed by chad). · Explain WhyDec 14 2016, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
110 lines
7 lines
src/
applications/
meta/
query/
2 lines
settings/
panel/
4 lines
view/
phui/
34 lines
100 lines
webroot/
rsrc/
css/
aphront/
10 lines
application/
config/
2 lines
flag/
2 lines
project/
4 lines
search/
2 lines
layout/
2 lines
phui/
object-item/
48 lines
68 lines
59 lines
13 lines
625 lines
43 lines
14 lines
2 lines
4 lines
2 lines
workboards/
68 lines
8 lines
js/
application/
maniphest/
2 lines

Diff 41029

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/css/application/config/config-page.css

Loading...
View Options

webroot/rsrc/css/application/flag/flag.css

Loading...
View Options

webroot/rsrc/css/application/project/project-view.css

Loading...
View Options

webroot/rsrc/css/application/search/search-results.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-big-ui.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-color.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-drag-ui.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-flush-ui.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css

Loading...
View Options

webroot/rsrc/css/phui/phui-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-crumbs-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workpanel.css

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-batch-selector.js

Loading...
Phabricator · Built by Phacility