Clean up Profile Menu Item page
ClosedPublic
Actions

Authored by chad on Dec 12 2016, 4:27 AM.

Tags

None

Referenced Files

	F13273474: D17030.diff
	Fri, May 31, 1:58 AM

	F13272584: D17030.diff
	Thu, May 30, 4:01 PM

	F13237971: D17030.id40966.diff
	Tue, May 21, 4:18 PM

	F13215798: D17030.id40967.diff
	Fri, May 17, 7:52 PM

	F13204370: D17030.diff
	Wed, May 15, 12:31 AM

	F13187287: D17030.diff
	Sat, May 11, 4:26 AM

	Unknown Object (File)
	Tue, May 7, 7:33 AM

	Unknown Object (File)
	May 3 2024, 6:52 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPd8b028b51bc0: Clean up Profile Menu Item page

Summary

Cleans up the UI on the page here, uses two column layout, places actions as actionlist instead of dropdown. Changes edit pages to dialogs.

Test Plan

Add an application, divider, link, and facts to a menu page.

Diff Detail

Repository

rP Phabricator

Branch

redesign-menu-item-engine (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14854
Build 19441: Run Core Tests
Build 19440: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40965.Dec 12 2016, 4:27 AM

chad retitled this revision from to Clean up Profile Menu Item page.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2016, 4:27 AM

Nice, this looks a lot better. That dropdown was definitely a bit weird.

src/applications/search/engine/PhabricatorProfileMenuEngine.php
634	Do we need this?

This revision is now accepted and ready to land.Dec 12 2016, 4:04 PM

comment

Closed by commit rPd8b028b51bc0: Clean up Profile Menu Item page (authored by chad, committed by chad). · Explain WhyDec 12 2016, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

51 lines

Diff 40965

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Clean up Profile Menu Item pageClosedPublicActions