Page MenuHomePhabricator
Differential D17030

Clean up Profile Menu Item page
ClosedPublic
Actions

Authored by chad on Dec 12 2016, 4:27 AM.
Tags
None
Referenced Files
F15417753: D17030.id40965.diff
Thu, Mar 20, 6:11 PM
F15407269: D17030.id40966.diff
Tue, Mar 18, 4:35 PM
F15388050: D17030.id40967.diff
Sat, Mar 15, 3:15 AM
F15381150: D17030.id40965.diff
Fri, Mar 14, 6:08 AM
F15333772: D17030.id40965.diff
Sat, Mar 8, 4:43 AM
F15333538: D17030.diff
Sat, Mar 8, 2:56 AM
Unknown Object (File)
Feb 18 2025, 12:11 PM
Unknown Object (File)
Feb 16 2025, 6:28 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPd8b028b51bc0: Clean up Profile Menu Item page
Summary

Cleans up the UI on the page here, uses two column layout, places actions as actionlist instead of dropdown. Changes edit pages to dialogs.

Test Plan

Add an application, divider, link, and facts to a menu page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40965.Dec 12 2016, 4:27 AM
chad retitled this revision from to Clean up Profile Menu Item page.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2016, 4:27 AM
epriestley accepted this revision.Dec 12 2016, 4:04 PM
epriestley edited edge metadata.

Nice, this looks a lot better. That dropdown was definitely a bit weird.

src/applications/search/engine/PhabricatorProfileMenuEngine.php
634

Do we need this?

This revision is now accepted and ready to land.Dec 12 2016, 4:04 PM
chad updated this revision to Diff 40966.Dec 12 2016, 4:36 PM
chad edited edge metadata.
  • comment
Closed by commit rPd8b028b51bc0: Clean up Profile Menu Item page (authored by chad, committed by chad). · Explain WhyDec 12 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
engine/
49 lines

Diff 40967

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
Phabricator · Built by Phacility