Add an ApplicationProfilePanel
ClosedPublic
Actions

Authored by chad on Dec 9 2016, 7:10 PM.

Details

Reviewers

epriestley

Commits

rPf0b695239186: Add an ApplicationProfilePanel

Summary

Allows applications to be added as profile menu items

Test Plan

Add an application to a project, see menu item, click on menu. Uninstall application, see menu without application.

Repository

rP Phabricator

Branch

application-panel (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

	Time	Test
	17 ms	PhabricatorPolicyDataTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorPolicyDataTestCase.php:228). ACTUAL VALUE
	1 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed.
		View Full Test Results (1 Failed · 334 Passed)

chad retitled this revision from to Add an ApplicationProfilePanel.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

If I uninstall the application, then click "Edit Menu", do I still see something sensible?
You could optionally let users rename these by adding another field to buildEditEngineFields(), so they can call "Maniphest" something like "Tasks" if they want.

src/applications/search/profilepanel/PhabricatorApplicationProfilePanel.php
39–48	I think it would be slightly better to use `PhabricatorApplicationQuery` with `withPHIDs(...)` here. In practice, it does the same thing, but we could optimize that more easily in the future if it ever shows up on a profile.