Page MenuHomePhabricator

Use futures to improve clustered repository main page performance
ClosedPublic

Authored by epriestley on Dec 8 2016, 2:44 PM.
Tags
None
Referenced Files
F14322246: D17009.id40924.diff
Wed, Dec 18, 12:35 PM
F14322244: D17009.id40923.diff
Wed, Dec 18, 12:35 PM
F14322239: D17009.diff
Wed, Dec 18, 12:35 PM
Unknown Object (File)
Mon, Dec 16, 11:16 PM
Unknown Object (File)
Thu, Dec 12, 12:17 AM
Unknown Object (File)
Sun, Dec 8, 1:59 PM
Unknown Object (File)
Thu, Dec 5, 8:16 AM
Unknown Object (File)
Tue, Dec 3, 7:20 PM
Subscribers
None

Details

Summary

Ref T11954. In cluster configurations, we get repository information by making HTTP calls over Conduit.

These are slower than local calls, so clustering imposes a performance penalty. However, we can use futures and parallelize them so that clustering actually improves overall performance.

When not running in clustered mode, this just makes us run stuff inline.

Test Plan
  • Browsed Git, Mercurial and Subversion repositories.
  • Locally, saw a 700ms wall time page drop to 200ms.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use futures to improve clustered repository main page performance.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.