Page MenuHomePhabricator
Differential D17002

Cache README content for repositories
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 5:37 PM.
Tags
None
Referenced Files
F19005451: D17002.diff
Nov 21 2025, 3:37 PM
F18867213: D17002.id40906.diff
Nov 3 2025, 10:16 PM
F18803726: D17002.id40905.diff
Oct 18 2025, 3:18 AM
F18790820: D17002.diff
Oct 15 2025, 7:32 PM
F18784765: D17002.diff
Oct 13 2025, 3:07 PM
F18590761: D17002.id.diff
Sep 12 2025, 7:04 AM
F18585515: D17002.diff
Sep 11 2025, 3:49 PM
F18508366: D17002.id.diff
Sep 5 2025, 2:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching
Commits
rPb869e742b9dc: Cache README content for repositories
Summary

Ref T11954. Especially with higher-latency file stores like S3, we can spend a lot of time reading README data and then pulling it out of file storage.

Instead, cache it.

Test Plan

Browsed a repostory with a README, saw faster pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40905.Dec 6 2016, 5:37 PM
epriestley retitled this revision from to Cache README content for repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
chad accepted this revision.Dec 6 2016, 5:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 5:45 PM
Closed by commit rPb869e742b9dc: Cache README content for repositories (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
67 lines

Diff 40906

View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
Phabricator · Built by Phacility