Paths

Table of Contentst

Differential D16988

Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0
ClosedPublic
Actions

Authored by epriestley on Dec 5 2016, 8:13 PM.

Tags

None

Referenced Files

	F14057302: D16988.diff
	Sun, Nov 17, 2:04 AM

	F14035860: D16988.id40875.diff
	Sun, Nov 10, 7:49 AM

	F13997635: D16988.id40873.diff
	Thu, Oct 24, 5:26 AM

	F13997634: D16988.id40875.diff
	Thu, Oct 24, 5:26 AM

	F13997633: D16988.id.diff
	Thu, Oct 24, 5:26 AM

	F13997632: D16988.id40874.diff
	Thu, Oct 24, 5:26 AM

	F13997570: D16988.diff
	Thu, Oct 24, 5:09 AM

	F13954974: D16988.diff
	Oct 13 2024, 11:43 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0

Commits

rP005d8493b034: Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0

Summary

Fixes T11940. In 2.11.0, Git has made a change so that newly-pushed changes are held in a temporary area until the hook accepts or rejects them.

This magic temporary area is only readable if the appropriate GIT_ENVIRONMENTAL_MAGIC variables are available. When executing git commands, pass them through from the calling context.

We're intentionally conservative about which variables we pass, and with good reason (see "httpoxy" in T11359). I think this continues to be the correct default behavior.

Test Plan

Upgraded to Git 2.11.0.
Tried to push over SSH, got a hook error.
Applied patch.
Pulled and pushed over SSH.
Pulled and pushed over HTTP.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40873.Dec 5 2016, 8:13 PM

epriestley retitled this revision from to Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.

epriestley updated this object.Dec 5 2016, 8:13 PM

chad accepted this revision.Dec 5 2016, 8:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2016, 8:14 PM

Reorganize $result a little better.

Closed by commit rP005d8493b034: Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0 (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2016, 8:45 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.Apr 29 2023, 2:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

6 lines

protocol/

DiffusionCommandEngine.php

2 lines

repository/

storage/

PhabricatorRepository.php

51 lines

Diff 40875

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...

src/applications/diffusion/protocol/DiffusionCommandEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...