Page MenuHomePhabricator
Differential D16985

Remove some no-op "canUninstall()" Application methods
ClosedPublic
Actions

Authored by epriestley on Dec 5 2016, 5:47 PM.
Tags
None
Referenced Files
F18839878: D16985.id.diff
Mon, Oct 27, 7:29 PM
F18834923: D16985.diff
Sun, Oct 26, 12:00 PM
F18827325: D16985.id.diff
Fri, Oct 24, 9:22 AM
F18804680: D16985.id40870.diff
Sat, Oct 18, 10:35 AM
F18747799: D16985.id40865.diff
Fri, Oct 3, 5:45 PM
F18390420: D16985.id40870.diff
Aug 29 2025, 6:53 AM
F18383376: D16985.id40870.diff
Aug 28 2025, 10:58 PM
F18050853: D16985.id.diff
Aug 3 2025, 9:18 PM
View All Files
Subscribers
hach-que

Details

Reviewers
chad
Commits
rP4a6229ee693b: Remove some no-op "canUninstall()" Application methods
Summary

The default behavior of these methods is to return true, so these overrides have no effect.

Test Plan

grep; poked around.

Diff Detail

Repository
rP Phabricator
Branch
uninstall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14751
Build 19281: Run Core Tests
Build 19280: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40865.Dec 5 2016, 5:47 PM
epriestley retitled this revision from to Remove some no-op "canUninstall()" Application methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: hach-que. · View Herald TranscriptDec 5 2016, 5:47 PM
chad accepted this revision.Dec 5 2016, 5:51 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2016, 5:51 PM
Closed by commit rP4a6229ee693b: Remove some no-op "canUninstall()" Application methods (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
application/
4 lines
nuance/
application/
4 lines
phragment/
application/
4 lines

Diff 40865

View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...
View Options

src/applications/nuance/application/PhabricatorNuanceApplication.php

Loading...
View Options

src/applications/phragment/application/PhabricatorPhragmentApplication.php

Loading...
Phabricator · Built by Phacility