Page MenuHomePhabricator
Differential D16978

Prevent double lightbox in lightbox comments
ClosedPublic
Actions

Authored by chad on Dec 2 2016, 6:53 PM.
Tags
None
Referenced Files
F13144498: D16978.diff
Fri, May 3, 8:14 AM
F13142687: D16978.diff
Fri, May 3, 6:30 AM
Unknown Object (File)
Thu, Apr 25, 2:13 AM
Unknown Object (File)
Wed, Apr 24, 10:42 AM
Unknown Object (File)
Wed, Apr 24, 10:41 AM
Unknown Object (File)
Wed, Apr 24, 10:41 AM
Unknown Object (File)
Wed, Apr 24, 10:41 AM
Unknown Object (File)
Fri, Apr 19, 5:48 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP49a20bde8e6b: Prevent double lightbox in lightbox comments
Summary

Ref T3612, prevents lightbox from spawning from inside a lightbox.

Test Plan

Click on file lightbox, leave file comment, click file comment, get take to file page instead of another lightbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40854.Dec 2 2016, 6:53 PM
chad retitled this revision from to Prevent double lightbox in lightbox comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2016, 6:53 PM
epriestley accepted this revision.Dec 2 2016, 6:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 6:54 PM
chad added a comment.Dec 2 2016, 6:56 PM

If there is a better solution, lmk, can wait until someone complains lightbox + lightbox are expected.

Closed by commit rP49a20bde8e6b: Prevent double lightbox in lightbox comments (authored by chad, committed by chad). · Explain WhyDec 2 2016, 6:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
view/
page/
1 line
webroot/
rsrc/
js/
core/
7 lines

Diff 40855

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility