Page MenuHomePhabricator

Prevent double lightbox in lightbox comments
ClosedPublic

Authored by chad on Dec 2 2016, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Sat, Mar 30, 6:55 PM
Unknown Object (File)
Thu, Mar 28, 1:19 AM
Unknown Object (File)
Mar 5 2024, 3:33 PM
Unknown Object (File)
Feb 20 2024, 7:12 AM
Unknown Object (File)
Feb 14 2024, 6:41 PM
Unknown Object (File)
Feb 3 2024, 1:17 PM
Unknown Object (File)
Jan 26 2024, 6:14 PM
Subscribers

Details

Summary

Ref T3612, prevents lightbox from spawning from inside a lightbox.

Test Plan

Click on file lightbox, leave file comment, click file comment, get take to file page instead of another lightbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Prevent double lightbox in lightbox comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 6:54 PM

If there is a better solution, lmk, can wait until someone complains lightbox + lightbox are expected.

This revision was automatically updated to reflect the committed changes.