Ref T3612, this adds a anchor around the large icon with hover state so you can download from here as well.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3612: Lightbox v2
- Commits
- rPaa6517a42b35: Make clicking on file icon in lightbox download file
Hover over .ics file, click, get download.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- download-ics (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14737 Build 19259: Run Core Tests Build 19258: arc lint + arc unit
Event Timeline
Comment Actions
This probably does the wrong thing if you click a file to bring up the lightbox, then open the comments, then click a file in the file's comments, then click the file icon. But presumably that's rare.
Comment Actions
To listen only under a particular node:
JX.DOM.listen(root, 'click, 'sigil', function(e) { ... });To find a node under a particular node:
var thing = JX.DOM.find(root, 'div', 'sigil');
Comment Actions
JX.Stratcom.listen() does not take a node, and listens on the whole document.
(Technically, JX.DOM.listen() just puts a unique ID on the node if it doesn't already have one, adds it to all your sigil specifications, then calls JX.Stratcom.listen().)