Page MenuHomePhabricator

Make clicking on file icon in lightbox download file
ClosedPublic

Authored by chad on Dec 2 2016, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:43 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Tue, Apr 2, 2:10 AM
Unknown Object (File)
Sun, Mar 31, 8:24 AM
Unknown Object (File)
Sat, Mar 30, 4:41 AM
Unknown Object (File)
Mar 5 2024, 12:33 AM
Unknown Object (File)
Feb 3 2024, 1:17 PM
Unknown Object (File)
Jan 26 2024, 6:14 PM
Subscribers

Details

Summary

Ref T3612, this adds a anchor around the large icon with hover state so you can download from here as well.

Test Plan

Hover over .ics file, click, get download.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Make clicking on file icon in lightbox download file.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
epriestley edited edge metadata.

This probably does the wrong thing if you click a file to bring up the lightbox, then open the comments, then click a file in the file's comments, then click the file icon. But presumably that's rare.

This revision is now accepted and ready to land.Dec 2 2016, 6:12 PM
This revision was automatically updated to reflect the committed changes.

How can I capture/listen to sigils only under a certain node?

To listen only under a particular node:

JX.DOM.listen(root, 'click, 'sigil', function(e) { ... });

To find a node under a particular node:

var thing = JX.DOM.find(root, 'div', 'sigil');

What does JX.Dom.listen vs JX.Stratcom.listen do?

JX.Stratcom.listen() does not take a node, and listens on the whole document.

(Technically, JX.DOM.listen() just puts a unique ID on the node if it doesn't already have one, adds it to all your sigil specifications, then calls JX.Stratcom.listen().)