Page MenuHomePhabricator

Improve error messages for running `git clone` against a Mercurial repository
ClosedPublic

Authored by epriestley on Dec 2 2016, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:59 AM
Unknown Object (File)
Thu, Dec 19, 12:23 AM
Unknown Object (File)
Wed, Dec 11, 11:27 AM
Unknown Object (File)
Mon, Dec 9, 6:18 AM
Unknown Object (File)
Sun, Dec 1, 2:50 PM
Unknown Object (File)
Thu, Nov 28, 10:26 PM
Unknown Object (File)
Mon, Nov 25, 8:01 AM
Unknown Object (File)
Oct 19 2024, 4:27 PM
Subscribers
None

Details

Summary

Fixes T11938.

Note that there's a subcase here: if you hg clone or svn checkout a short /source/ URI that ends in .git, we miss the lookup and don't get this far, so you still get a generic error message.

Hopefully it is clear enough on its own that proto://.../blah.git is, in fact, a Git repository, since it says ".git" at the end.

If that doesn't prove to be true, we can be more surgical about this.

Test Plan
$ git clone ssh://local@localvault.phacility.com/source/quack.notgit/
Cloning into 'quack.notgit'...
phabricator-ssh-exec: This repository ("quack.notgit") is not a Git repository. Use "hg" to interact with this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
$ hg clone ssh://local@localvault.phacility.com/source/phabx
remote: phabricator-ssh-exec: This repository ("phabx") is not a Mercurial repository. Use "git" to interact with this repository.
abort: no suitable response from remote hg!

Diff Detail

Repository
rP Phabricator
Branch
gitclone1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14733
Build 19254: Run Core Tests
Build 19253: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve error messages for running `git clone` against a Mercurial repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 3:25 PM
This revision was automatically updated to reflect the committed changes.