Page MenuHomePhabricator

Explicitly update the repository URI index after making a URI edit
ClosedPublic

Authored by epriestley on Dec 1 2016, 10:27 PM.

Details

Summary

Fixes T11936. After editing a repository URI, we were not correctly updating the URI index.

Any other edit to the repository would update the index, and this index is only really used by arc to figure out which repository a working copy belongs to, so that's how this evaded detection for this long. In particular, creating a repository would usually have an edit after any URI edits, to activate it, which would build the index correctly.

Test Plan
  • Added a new URI to a repository.
  • Verified it was immediately reflected in the repository_uriindex table.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 40843.Dec 1 2016, 10:27 PM
epriestley retitled this revision from to Explicitly update the repository URI index after making a URI edit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Dec 1 2016, 10:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2016, 10:27 PM
This revision was automatically updated to reflect the committed changes.