Page MenuHomePhabricator

Make lightbox buttons more roundy

Authored by chad on Nov 29 2016, 7:01 PM.



Ref T3612. Mobilizes the new lightbox, changes large buttons to circle icons like Conpherence.

Test Plan

Click each new button on desktop, mobile.

Diff Detail

rP Phabricator
lightbox-mobile (branched from master)
Lint OK
Unit Tests OK
Build Status
Buildable 14705
Build 19214: Run Core Tests
Build 19213: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40816.Nov 29 2016, 7:01 PM
chad retitled this revision from to Make lightbox buttons more roundy.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
chad added a comment.Nov 29 2016, 7:40 PM

Yeah, I'm stumped.

chad added a comment.Nov 29 2016, 7:40 PM

I feel like something is eating the click, but no idea wat.

chad updated this revision to Diff 40817.Nov 29 2016, 8:00 PM
  • Think this fixes it
chad added a comment.Nov 29 2016, 8:01 PM

Can you run this locally? I think I have some issues with local.json messing up my download / files app. Adding in core and services also makes corgi no longer work for me, so there's that too.

epriestley accepted this revision.Nov 29 2016, 8:21 PM
epriestley edited edge metadata.

Seems to work OK for me locally.

This revision is now accepted and ready to land.Nov 29 2016, 8:21 PM
This revision was automatically updated to reflect the committed changes.