Page MenuHomePhabricator
Differential D16961

Make lightbox buttons more roundy
ClosedPublic
Actions

Authored by chad on Nov 29 2016, 7:01 PM.
Tags
None
Referenced Files
F13045124: D16961.diff
Wed, Apr 17, 8:25 PM
Unknown Object (File)
Thu, Apr 11, 3:50 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Fri, Apr 5, 11:43 AM
Unknown Object (File)
Wed, Apr 3, 10:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rPf844280d360c: Make lightbox buttons more roundy
Summary

Ref T3612. Mobilizes the new lightbox, changes large buttons to circle icons like Conpherence.

Test Plan

Click each new button on desktop, mobile.

Diff Detail

Repository
rP Phabricator
Branch
lightbox-mobile (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14705
Build 19214: Run Core Tests
Build 19213: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40816.Nov 29 2016, 7:01 PM
chad retitled this revision from to Make lightbox buttons more roundy.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 29 2016, 7:01 PM
chad added a comment.Nov 29 2016, 7:40 PM

Yeah, I'm stumped.

chad added a comment.Nov 29 2016, 7:40 PM

I feel like something is eating the click, but no idea wat.

chad updated this revision to Diff 40817.Nov 29 2016, 8:00 PM
  • Think this fixes it
chad added a comment.Nov 29 2016, 8:01 PM

Can you run this locally? I think I have some issues with local.json messing up my download / files app. Adding in core and services also makes corgi no longer work for me, so there's that too.

epriestley accepted this revision.Nov 29 2016, 8:21 PM
epriestley edited edge metadata.

Seems to work OK for me locally.

This revision is now accepted and ready to land.Nov 29 2016, 8:21 PM
Closed by commit rPf844280d360c: Make lightbox buttons more roundy (authored by chad, committed by chad). · Explain WhyNov 29 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
44 lines
src/
view/
page/
8 lines
webroot/
rsrc/
css/
phui/
5 lines
12 lines
32 lines
js/
core/
24 lines

Diff 40817

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-panel.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility