Page MenuHomePhabricator

Make lightbox buttons more roundy
ClosedPublic

Authored by chad on Nov 29 2016, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 3:50 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Fri, Apr 5, 11:43 AM
Unknown Object (File)
Wed, Apr 3, 10:14 PM
Unknown Object (File)
Thu, Mar 28, 5:25 PM
Subscribers

Details

Summary

Ref T3612. Mobilizes the new lightbox, changes large buttons to circle icons like Conpherence.

Test Plan

Click each new button on desktop, mobile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Make lightbox buttons more roundy.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.

I feel like something is eating the click, but no idea wat.

Can you run this locally? I think I have some issues with local.json messing up my download / files app. Adding in core and services also makes corgi no longer work for me, so there's that too.

epriestley edited edge metadata.

Seems to work OK for me locally.

This revision is now accepted and ready to land.Nov 29 2016, 8:21 PM
This revision was automatically updated to reflect the committed changes.