Page MenuHomePhabricator

When running a fulltext query with no query, enforce order by document creation date
ClosedPublic

Authored by epriestley on Nov 29 2016, 6:40 PM.
Tags
None
Referenced Files
F13149487: D16960.diff
Sat, May 4, 9:28 AM
Unknown Object (File)
Thu, Apr 25, 9:19 PM
Unknown Object (File)
Thu, Apr 25, 1:13 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Apr 2 2024, 7:13 PM
Subscribers
None

Details

Summary

Fixes T11929. When running with a query, we no longer enforce an order on the subquery join to produce results more quickly when searching for common strings.

However, this means that empty queries (like those issued by "Close as Duplicate") don't order subquery results.

Restore a dateCreated order if there is no query text.

Test Plan

Artificially set limit to 10, still saw 10 most recent tasks.

Diff Detail

Repository
rP Phabricator
Branch
ftorder1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14703
Build 19210: Run Core Tests
Build 19209: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When running a fulltext query with no query, enforce order by document creation date.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 6:41 PM
This revision was automatically updated to reflect the committed changes.