Page MenuHomePhabricator
Differential D16956

Make the modal choice between "Edit This Event" and "Edit Future Events" more clear
ClosedPublic
Actions

Authored by epriestley on Nov 28 2016, 5:49 PM.
Tags
None
Referenced Files
F15448114: D16956.diff
Fri, Mar 28, 3:14 AM
F15435332: D16956.id40807.diff
Tue, Mar 25, 7:49 AM
F15414575: D16956.id40807.diff
Thu, Mar 20, 1:15 AM
F15408802: D16956.diff
Wed, Mar 19, 1:25 AM
Unknown Object (File)
Mon, Mar 3, 12:51 PM
Unknown Object (File)
Mon, Mar 3, 11:23 AM
Unknown Object (File)
Feb 21 2025, 5:03 AM
Unknown Object (File)
Feb 19 2025, 12:19 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
T11909: Recurring Events: "Edit all Future Events" edits past instances as well
Commits
rP5cc4f6407ceb: Make the modal choice between "Edit This Event" and "Edit Future Events" more…
Summary

Fixes T11909. Ref T11816. Instead of offering a dropdown with choices between "Edit/Cancel/Reinstate This Event" and "Edit/Cancel/Reinstate Future Events", make the choice more explicit.

This dialog ends up pretty wordy but this edit is rare, so I think that's alright.

Test Plan

Screen Shot 2016-11-28 at 9.44.05 AM.png (1×1 px, 191 KB)

Diff Detail

Repository
rP Phabricator
Branch
ceditmode
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14695
Build 19198: Run Core Tests
Build 19197: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40807.Nov 28 2016, 5:49 PM
epriestley retitled this revision from to Make the modal choice between "Edit This Event" and "Edit Future Events" more clear.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11909: Recurring Events: "Edit all Future Events" edits past instances as well, T11816: Calendar: Feedback and Suggestions.
epriestley mentioned this in T11909: Recurring Events: "Edit all Future Events" edits past instances as well.Nov 28 2016, 5:50 PM
chad accepted this revision.Nov 28 2016, 6:46 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 6:46 PM
Closed by commit rP5cc4f6407ceb: Make the modal choice between "Edit This Event" and "Edit Future Events" more… (authored by epriestley, committed by epriestley). · Explain WhyNov 28 2016, 6:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
52 lines
32 lines

Diff 40807

View Options

src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
Phabricator · Built by Phacility