Page MenuHomePhabricator

Fix an issue where all-day events had durations applied incorrectly
ClosedPublic

Authored by epriestley on Nov 28 2016, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 6 2026, 4:45 AM
Unknown Object (File)
Apr 7 2026, 5:06 AM
Unknown Object (File)
Apr 3 2026, 1:36 AM
Unknown Object (File)
Feb 7 2026, 7:10 AM
Unknown Object (File)
Feb 1 2026, 9:27 PM
Unknown Object (File)
Jan 30 2026, 2:23 AM
Unknown Object (File)
Jan 29 2026, 8:09 PM
Unknown Object (File)
Jan 21 2026, 12:30 AM
Subscribers
None

Details

Summary

Ref T11816. User-visible bug here was that availability dots (away/busy) for all-day events might not appear correctly if the viewer timezone and event timezone differ.

Underlying issue was that when adding a duration (one day) to an all-day event datetime, we incorrectly used the viewer timezone as part of the calculation.

Instead, base the calculation on a clone of the event with no viewer timezone.

Test Plan
  • Added failing unit test, made it pass.
  • Saw proper availability dots for all-day events in Phabricator.

Diff Detail

Repository
rPHU libphutil
Branch
time1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14688
Build 19188: Run Core Tests
Build 19187: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an issue where all-day events had durations applied incorrectly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 4:30 PM
This revision was automatically updated to reflect the committed changes.