Page MenuHomePhabricator
Differential D16951

Remove english from lightbox javascript
ClosedPublic
Actions

Authored by chad on Nov 28 2016, 1:59 AM.
Tags
None
Referenced Files
F15448338: D16951.id40802.diff
Fri, Mar 28, 4:17 AM
F15447223: D16951.id40798.diff
Thu, Mar 27, 10:35 PM
F15446241: D16951.id.diff
Thu, Mar 27, 5:54 PM
F15441786: D16951.diff
Wed, Mar 26, 7:53 PM
F15423084: D16951.id.diff
Sat, Mar 22, 12:46 PM
F15422087: D16951.id40798.diff
Sat, Mar 22, 5:23 AM
F15405397: D16951.id40802.diff
Tue, Mar 18, 11:24 AM
F15388668: D16951.id40798.diff
Sat, Mar 15, 4:14 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP3edd01bc0fa2: Remove english from lightbox javascript
Summary

Reduces to x / y for lightbox. Adds spacing. Ref T3612

Test Plan

Review spacing in sandbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40798.Nov 28 2016, 1:59 AM
chad retitled this revision from to Remove english from lightbox javascript.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2016, 1:59 AM
epriestley accepted this revision.Nov 28 2016, 2:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 2:43 PM
Closed by commit rP3edd01bc0fa2: Remove english from lightbox javascript (authored by chad, committed by chad). · Explain WhyNov 28 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
css/
phui/
2 lines
js/
core/
2 lines

Diff 40802

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility