Spruce up the file embeds a little more, hover state, icons, file size.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3612: Lightbox v2
- Commits
- rPdece7af50bff: Prettier file embeds
Add a psd and pdf, see new icons. Check differential, still see icons there too. Test mobile, desktop.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- files-remarkup (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 14684 Build 19181: Run Core Tests Build 19180: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 2 ms | PhabricatorLocalTimeTestCase::Unknown Unit Message (" ") EXCEPTION (AphrontNotSupportedQueryException): Database isolation currently only supports some queries. You are trying to issue a query which does not begin with an allowed keyword (INSERT, UPDATE, DELETE, START, SAVEPOINT, COMMIT, ROLLBACK): 'SELECT * FROM <C> WHERE (builtinKey IN ('<S>')) ORDER BY <C> DESC '.
#0 /var/www/html/dev/core/lib/libphutil/src/xsprintf/queryfx.php(8): AphrontIsolatedDatabaseConnection->executeRawQuery('SELECT * FROM <...')
#1 [internal function]: queryfx(Object(AphrontIsolatedDatabaseConnection), '%Q FROM %T %Q %...', 'SELECT *', 'user_preference...', '', '', 'WHERE (builtinK...', '', '', 'ORDER BY <C> DE...', '')
| |
| 1 ms | AlmanacNamesTestCase::Unknown Unit Message (" ") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 6 assertions passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| View Full Test Results (1 Failed · 344 Passed) |
Event Timeline
Comment Actions
That test issue isn't you, I think it's the unit tests trying to load timezone preferences for the logged-out test user after the recent "logged-out viewers use global default settings" thing, although I'm not sure why it hasn't triggered before. I'll take a look at it.