Differential D16950

Prettier file embeds
ClosedPublic
Actions

Authored by chad on Nov 27 2016, 10:01 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T3612: Lightbox v2

Commits

rPdece7af50bff: Prettier file embeds

Summary

Spruce up the file embeds a little more, hover state, icons, file size.

Test Plan

Add a psd and pdf, see new icons. Check differential, still see icons there too. Test mobile, desktop.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40796.Nov 27 2016, 10:01 PM

chad retitled this revision from to Prettier file embeds.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 27 2016, 10:01 PM

chad edited the test plan for this revision. (Show Details)Nov 27 2016, 10:03 PM

idk about that lint?

That test issue isn't you, I think it's the unit tests trying to load timezone preferences for the logged-out test user after the recent "logged-out viewers use global default settings" thing, although I'm not sure why it hasn't triggered before. I'll take a look at it.

This revision is now accepted and ready to land.Nov 27 2016, 10:36 PM

Closed by commit rPdece7af50bff: Prettier file embeds (authored by chad, committed by chad). · Explain WhyNov 27 2016, 10:57 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T3612: Lightbox v2.Nov 27 2016, 11:08 PM