Page MenuHomePhabricator

Prettier file embeds
ClosedPublic

Authored by chad on Nov 27 2016, 10:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Tue, Apr 2, 4:13 PM
Unknown Object (File)
Mar 15 2024, 9:57 AM
Unknown Object (File)
Feb 23 2024, 7:09 AM
Unknown Object (File)
Feb 21 2024, 8:10 AM
Unknown Object (File)
Feb 14 2024, 1:43 AM
Unknown Object (File)
Feb 12 2024, 2:44 AM
Unknown Object (File)
Feb 3 2024, 1:13 PM
Subscribers

Details

Summary

Spruce up the file embeds a little more, hover state, icons, file size.

Test Plan

Add a psd and pdf, see new icons. Check differential, still see icons there too. Test mobile, desktop.

pasted_file (518×432 px, 62 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Prettier file embeds.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

That test issue isn't you, I think it's the unit tests trying to load timezone preferences for the logged-out test user after the recent "logged-out viewers use global default settings" thing, although I'm not sure why it hasn't triggered before. I'll take a look at it.

This revision is now accepted and ready to land.Nov 27 2016, 10:36 PM
This revision was automatically updated to reflect the committed changes.