Page MenuHomePhabricator
Differential D16946

If InnoDB FULLTEXT is available, use it for for fulltext indexes
ClosedPublic
Actions

Authored by epriestley on Nov 25 2016, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 11:40 PM
Unknown Object (File)
Fri, Jan 31, 3:47 PM
Unknown Object (File)
Mon, Jan 27, 11:36 PM
Unknown Object (File)
Sun, Jan 26, 11:38 AM
Unknown Object (File)
Sun, Jan 26, 10:20 AM
Unknown Object (File)
Tue, Jan 21, 3:56 PM
Unknown Object (File)
Tue, Jan 21, 12:45 PM
Unknown Object (File)
Thu, Jan 16, 12:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud)
Commits
rPd54c14c64444: If InnoDB FULLTEXT is available, use it for for fulltext indexes
Summary

Ref T11741. I'll wait until the release cut to land this; it just adds a test for InnoDB FULLTEXT being available instead of always returning false.

Test Plan
  • Ran with InnoDB fulltext locally for a day and a half without issues.
  • Ran bin/storage upgrade, saw it detect InnoDB fulltext.

Diff Detail

Repository
rP Phabricator
Branch
search8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14668
Build 19162: Run Core Tests
Build 19161: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40780.Nov 25 2016, 9:57 PM
epriestley retitled this revision from to If InnoDB FULLTEXT is available, use it for for fulltext indexes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
chad accepted this revision.Nov 25 2016, 10:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2016, 10:22 PM
Closed by commit rPd54c14c64444: If InnoDB FULLTEXT is available, use it for for fulltext indexes (authored by epriestley, committed by epriestley). · Explain WhyNov 25 2016, 11:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
storage/
document/
27 lines

Diff 40780

View Options

src/applications/search/storage/document/PhabricatorSearchDocument.php

Loading...
Phabricator · Built by Phacility