When a Phortune subscription has a removed payment method, be more explicit about it
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 9:37 PM.

Details

Reviewers

Commits

rP8958d68ec648: When a Phortune subscription has a removed payment method, be more explicit…

Summary

Currently, when a payment method is invalid we still render the full name and let you save the form without making changes. This can be confusing.

Instead:

Render "<Deleted Payment Method>", literally.
Render an error immediately.
Prevent the form from being saved without changing the method.

Test Plan

Screen Shot 2016-11-23 at 1.35.34 PM.png (1×1 px, 135 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40764.Nov 23 2016, 9:37 PM

epriestley retitled this revision from to When a Phortune subscription has a removed payment method, be more explicit about it.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Nov 23 2016, 9:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2016, 9:50 PM

Closed by commit rP8958d68ec648: When a Phortune subscription has a removed payment method, be more explicit… (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 10:07 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.Feb 7 2017, 3:22 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

PhortuneSubscriptionEditController.php

24 lines

Diff 40766

View Options

src/applications/phortune/controller/PhortuneSubscriptionEditController.php

When a Phortune subscription has a removed payment method, be more explicit about itClosedPublicActions