Page MenuHomePhabricator

Rebuild "arc browse" using refs and hardpoints
ClosedPublic

Authored by epriestley on Nov 23 2016, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 5, 11:40 AM
Unknown Object (File)
Wed, Aug 3, 8:04 PM
Unknown Object (File)
Tue, Aug 2, 1:24 PM
Unknown Object (File)
Mon, Jul 25, 3:11 PM
Unknown Object (File)
Mon, Jul 25, 11:29 AM
Unknown Object (File)
Jul 16 2022, 2:21 PM
Unknown Object (File)
Jul 16 2022, 5:14 AM
Unknown Object (File)
Jul 14 2022, 7:52 AM
Subscribers
None

Details

Summary

Ref T10895. This mostly modularizes arc browse and puts it on ref/hardpoint infrastructure. Feels okay-ish? Major gripes:

  • Messaging for "some stuff won't work because you're in a random directory, not a working copy" could be better, but I think I want something like the "Guidance" infrastructure for this.
  • The requiresStuff() / desiresStuff() interactions on Workflow continue to feel bad, but I think I can sneak by without fixing those for now.
  • I want to improve some of the other UI/UX stuff but this diff is already gigantic.
Test Plan

Ran arc browse ., arc browse master, arc browse README.md, inside and outside working directories.

Diff Detail

Repository
rARC Arcanist
Branch
xp3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/browse/workflow/ArcanistBrowseWorkflow.php:94XHP16TODO Comment
Advicesrc/ref/ArcanistRepositoryRef.php:67XHP16TODO Comment
Advicesrc/ref/ArcanistRepositoryRef.php:74XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14632
Build 19107: Run Core Tests
Build 19106: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Rebuild "arc browse" using refs and hardpoints.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.