Paths

Table of Contentst

Fix two setup issues arising from partitioning support
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 12:47 PM.

Details

Reviewers

Maniphest Tasks

T11044: Support partitioning application databases across multiple database hosts
T11916: "storage upgrade" fails to acquire an adjustment lock on databases with long hostnames

Commits

rPce18a8e20820: Fix two setup issues arising from partitioning support

Summary

Ref T11044.

Use shorter lock names. Fixes T11916.
These granular exceptions now always raise as a more generic "Cluster" exception, even for a single host, because there's less special code around running just one database.

Test Plan

Configured bad mysql.port, ran bin/storage upgrade, got a more helpful error message.
Ran bin/storage upgrade --trace, saw shorter lock names.

Diff Detail

Repository

rP Phabricator

Branch

adjust1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14631
Build 19105: Run Core Tests
Build 19104: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40740.Nov 23 2016, 12:47 PM

epriestley retitled this revision from to Fix two setup issues arising from partitioning support.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11916: "storage upgrade" fails to acquire an adjustment lock on databases with long hostnames, T11044: Support partitioning application databases across multiple database hosts.

epriestley mentioned this in T11916: "storage upgrade" fails to acquire an adjustment lock on databases with long hostnames.Nov 23 2016, 12:57 PM

chad accepted this revision.Nov 23 2016, 3:10 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2016, 3:10 PM

Closed by commit rPce18a8e20820: Fix two setup issues arising from partitioning support (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

env/

PhabricatorEnv.php

8 lines

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

4 lines

Diff 40740

View Options

src/infrastructure/env/PhabricatorEnv.php