Page MenuHomePhabricator
Differential D16924

Fix two setup issues arising from partitioning support
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 12:47 PM.
Tags
None
Referenced Files
F15541962: D16924.id.diff
Fri, Apr 25, 2:43 PM
F15534780: D16924.diff
Thu, Apr 24, 2:03 AM
F15531933: D16924.id40740.diff
Wed, Apr 23, 1:53 PM
F15525449: D16924.diff
Mon, Apr 21, 2:30 PM
F15514344: D16924.id40742.diff
Fri, Apr 18, 2:11 AM
F15513055: D16924.diff
Thu, Apr 17, 4:07 PM
F15420975: D16924.id40742.diff
Mar 21 2025, 7:43 PM
F15403166: D16924.id.diff
Mar 18 2025, 2:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11044: Support partitioning application databases across multiple database hosts
T11916: "storage upgrade" fails to acquire an adjustment lock on databases with long hostnames
Commits
rPce18a8e20820: Fix two setup issues arising from partitioning support
Summary

Ref T11044.

  • Use shorter lock names. Fixes T11916.
  • These granular exceptions now always raise as a more generic "Cluster" exception, even for a single host, because there's less special code around running just one database.
Test Plan
  • Configured bad mysql.port, ran bin/storage upgrade, got a more helpful error message.
  • Ran bin/storage upgrade --trace, saw shorter lock names.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
infrastructure/
env/
8 lines
storage/
management/
workflow/
4 lines

Diff 40742

View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility