Page MenuHomePhabricator

Begin modernizing the Arcanist interaction with Conduit
ClosedPublic

Authored by epriestley on Nov 23 2016, 12:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 28, 1:03 AM
Unknown Object (File)
Sun, Jun 26, 4:40 PM
Unknown Object (File)
Mon, Jun 20, 2:39 PM
Unknown Object (File)
Fri, Jun 17, 11:25 PM
Unknown Object (File)
Wed, Jun 15, 5:46 PM
Unknown Object (File)
Fri, Jun 10, 1:59 PM
Unknown Object (File)
Apr 13 2017, 9:54 AM
Unknown Object (File)
Mar 28 2017, 5:29 PM
Subscribers

Details

Summary

Ref T10895.

NOTE: I'm going to land this and other changes to a new experimental branch until arc is more substantially rebuilt, since everything I touch feels like it requires me to rebuild 30 other things first.

Currently, many arc workflows are unnecessarily slow because they call conduit.connect on startup. There's no need to do this with the modern way the API works, and we've generally moved away from explicit version testing to more granular capability testing on specific workflows.

Additionally, some workflows like arc patch are huge messes (see T11434) because they're trying to run in anonymous mode but it doesn't really work with all the upfront stuff Conduit does now. It's not possible, in the general case, for a workflow to know upfront if it needs Conduit or not.

And:

  • ArcanistWorkflow has piles of Conduit logic, but should not.
  • Pooling Conduit requests isn't very easy.
  • There's a lot of general cruft around the workflow.
  • We should drop certificate support.

This pulls out Conduit into a separate on-demand class with modern support, future pooling, less cruft, inline handling of login issues, and generally less garbage.

Also adds an --anonymous flag, mostly to make testing easier.

Test Plan

Ran arc browse, used --anonymous and --trace, fiddled with credentials, got approximatley the same behavior that mainline arc has.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin modernizing the Arcanist interaction with Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

lgtmacro

scripts/arcanist.php
39

conflicts with token?

This revision is now accepted and ready to land.Nov 23 2016, 1:06 AM
scripts/arcanist.php
39

There's no builtin support for "conflicts" here so the official behavior is "--conduit-token" changes the token, then "--anonymous" ignores it.

iiam

This revision was automatically updated to reflect the committed changes.