Page MenuHomePhabricator
Differential D16918

Restyle remarkup file links
ClosedPublic
Actions

Authored by chad on Nov 22 2016, 9:19 PM.
Tags
None
Referenced Files
F15511157: D16918.id40730.diff
Thu, Apr 17, 12:08 AM
F15479326: D16918.id.diff
Tue, Apr 8, 6:18 AM
F15467255: D16918.id40730.diff
Thu, Apr 3, 1:52 PM
F15452503: D16918.id40732.diff
Sat, Mar 29, 5:21 AM
F15451468: D16918.id40730.diff
Fri, Mar 28, 10:16 PM
F15449828: D16918.id40730.diff
Fri, Mar 28, 12:23 PM
F15449443: D16918.id.diff
Fri, Mar 28, 10:17 AM
F15448670: D16918.id40730.diff
Fri, Mar 28, 6:12 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rPadd20783abb9: Restyle remarkup file links
Summary

Removes the icon image, uses font awesome. Better spacing.

Test Plan

Attach files to task, see new layout. click file, click download.

Diff Detail

Repository
rP Phabricator
Branch
file-embed (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14622
Build 19091: Run Core Tests
Build 19090: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40730.Nov 22 2016, 9:19 PM
chad retitled this revision from to Restyle remarkup file links.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 22 2016, 9:19 PM
chad added a task: T3612: Lightbox v2.Nov 22 2016, 9:20 PM
epriestley accepted this revision.Nov 22 2016, 9:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 9:48 PM
epriestley added a comment.Nov 22 2016, 9:48 PM

(Can we remove the .png completely? Or is it still used?)

webroot/rsrc/css/core/remarkup.css
388–390

Oh, empty CSS rule here.

Closed by commit rPadd20783abb9: Restyle remarkup file links (authored by chad, committed by chad). · Explain WhyNov 22 2016, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
layout/
8 lines
webroot/
rsrc/
css/
core/
19 lines

Diff 40730

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorFileLinkView.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility