Page MenuHomePhabricator
Differential D16917

Allow commenting on non-viewable lightbox files
ClosedPublic
Actions

Authored by chad on Nov 22 2016, 7:27 PM.
Tags
None
Referenced Files
F14362395: D16917.id40729.diff
Fri, Dec 20, 12:54 PM
Unknown Object (File)
Thu, Dec 19, 10:42 AM
Unknown Object (File)
Thu, Dec 19, 8:03 AM
Unknown Object (File)
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Wed, Dec 18, 2:15 PM
Unknown Object (File)
Thu, Dec 5, 7:07 AM
Unknown Object (File)
Tue, Dec 3, 10:16 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP0aa3f8b86bff: Allow commenting on non-viewable lightbox files
Summary

Removes the viewable restriction on embedded files. Builds a basic lightbox UI for commenting.

Test Plan

Add psd, pdf to Maniphest task, clicked on download, comment, left comment. Closed box.

Screen Shot 2016-11-22 at 11.21.39 AM.png (1×2 px, 202 KB)

Diff Detail

Repository
rP Phabricator
Branch
lightbox-not-viewable (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14620
Build 19088: Run Core Tests
Build 19087: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40728.Nov 22 2016, 7:27 PM
chad retitled this revision from to Allow commenting on non-viewable lightbox files.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 22 2016, 7:27 PM
chad edited the test plan for this revision. (Show Details)Nov 22 2016, 7:28 PM
epriestley accepted this revision.Nov 22 2016, 7:28 PM
epriestley edited edge metadata.

glorious

This revision is now accepted and ready to land.Nov 22 2016, 7:28 PM
chad added a task: T3612: Lightbox v2.Nov 22 2016, 7:29 PM
Closed by commit rP0aa3f8b86bff: Allow commenting on non-viewable lightbox files (authored by chad, committed by chad). · Explain WhyNov 22 2016, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
files/
controller/
11 lines
view/
layout/
11 lines
page/
4 lines
webroot/
rsrc/
css/
phui/
6 lines
28 lines
js/
core/
58 lines

Diff 40728

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...
View Options

src/view/layout/PhabricatorFileLinkView.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-panel.css

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility