Paths

Table of Contentst

Differential D16909

Remove "mysql.implementation" configuration
ClosedPublic
Actions

Authored by epriestley on Nov 22 2016, 1:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 3:29 PM

	Unknown Object (File)
	Fri, Dec 20, 9:25 AM

	Unknown Object (File)
	Thu, Dec 19, 3:06 AM

	Unknown Object (File)
	Wed, Dec 18, 2:14 PM

	Unknown Object (File)
	Wed, Dec 18, 2:14 PM

	Unknown Object (File)
	Wed, Dec 18, 2:14 PM

	Unknown Object (File)
	Mon, Dec 16, 5:20 AM

	Unknown Object (File)
	Sat, Dec 14, 6:31 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10931: Changing mysql.implementation setting doesn't work
T11044: Support partitioning application databases across multiple database hosts

Commits

rPbac27fb40363: Remove "mysql.implementation" configuration

Summary

Ref T11044. Fixes T10931. This option has essentially never been useful for anything, and we've picked the best implementation for a long time (MySQLi if available, MySQL if not).

I am not aware of any reason to ever set this manually. If someone comes up with some bizarre but legitimate use case that I haven't thought of, we can modularize it.

Test Plan

Browsed around. Grepped for mysql.implementation.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40705.Nov 22 2016, 1:05 AM

epriestley retitled this revision from to Remove "mysql.implementation" configuration.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11044: Support partitioning application databases across multiple database hosts, T10931: Changing mysql.implementation setting doesn't work.

epriestley mentioned this in T10931: Changing mysql.implementation setting doesn't work.Nov 22 2016, 1:08 AM

chad accepted this revision.Nov 22 2016, 1:29 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2016, 1:29 AM

• liugev6 added a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 8:51 AM

epriestley removed a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 12:09 PM

Closed by commit rPbac27fb40363: Remove "mysql.implementation" configuration (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2016, 12:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

3 lines

option/

PhabricatorMySQLConfigOptions.php

17 lines

console/

plugin/

DarkConsoleServicesPlugin.php

4 lines

infrastructure/

cluster/

PhabricatorDatabaseRef.php

14 lines

storage/

lisk/

PhabricatorLiskDAO.php

19 lines

management/

PhabricatorStorageManagementAPI.php

7 lines

Diff 40711

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorMySQLConfigOptions.php

Loading...

src/applications/console/plugin/DarkConsoleServicesPlugin.php

Loading...

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...