Differential D16908

Don't let users pick "whatever.git" as a repository short name, make "." work
ClosedPublic
Actions

Authored by epriestley on Nov 21 2016, 11:46 PM.

Tags

None

Referenced Files

	F14382816: D16908.diff
	Sat, Dec 21, 6:31 AM

	Unknown Object (File)
	Thu, Dec 19, 9:20 AM

	Unknown Object (File)
	Thu, Dec 19, 3:06 AM

	Unknown Object (File)
	Wed, Dec 18, 2:14 PM

	Unknown Object (File)
	Wed, Dec 18, 2:14 PM

	Unknown Object (File)
	Tue, Dec 17, 11:00 PM

	Unknown Object (File)
	Tue, Dec 3, 11:14 PM

	Unknown Object (File)
	Wed, Nov 27, 10:33 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11902: Periods in repository shortnames make the repo unreachable

Commits

rPbf1cbc2499c7: Don't let users pick "whatever.git" as a repository short name, make "." work

Summary

Fixes T11902.

Periods now work in short names.
If you try to name something ".git", no dice.

Test Plan

Tried to name something "quack.git", was politely rejected.
Named something "quack.notgit", and it worked fine.
Cloned Mercurial and Git repositories over SSH with ".git" and non-".git" variants without hitting any issues.

Diff Detail

Repository

Branch

deambig1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14592
Build 19047: Run Core Tests
Build 19046: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40698.Nov 21 2016, 11:46 PM

epriestley retitled this revision from to Don't let users pick "whatever.git" as a repository short name, make "." work.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11902: Periods in repository shortnames make the repo unreachable.

chad accepted this revision.Nov 21 2016, 11:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 21 2016, 11:46 PM

epriestley added inline comments.Nov 21 2016, 11:47 PM

src/applications/repository/storage/PhabricatorRepository.php
596–597	I couldn't figure out what this was talking about after some probing, so I think we're fine. SSH clones with Mercurial definitely work. Possibly we haven't seen the end of this.

Closed by commit rPbf1cbc2499c7: Don't let users pick "whatever.git" as a repository short name, make "." work (authored by epriestley, committed by epriestley). · Explain WhyNov 21 2016, 11:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

2 lines

controller/

DiffusionController.php

2 lines

DiffusionServeController.php

7 lines

repository/

storage/

PhabricatorRepository.php

28 lines

__tests__/

PhabricatorRepositoryTestCase.php

3 lines

Diff 40698

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...

src/applications/diffusion/controller/DiffusionController.php

Loading...

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php

Loading...