Page MenuHomePhabricator

Don't let users pick "whatever.git" as a repository short name, make "." work
ClosedPublic

Authored by epriestley on Nov 21 2016, 11:46 PM.
Tags
None
Referenced Files
F18806720: D16908.id.diff
Sat, Oct 18, 9:16 PM
F18768246: D16908.id.diff
Wed, Oct 8, 2:32 AM
F18767612: D16908.diff
Tue, Oct 7, 11:25 PM
F18654194: D16908.id40698.diff
Sep 22 2025, 4:04 AM
F18629572: D16908.diff
Sep 16 2025, 9:16 AM
F18574595: D16908.diff
Sep 10 2025, 11:11 AM
F18241426: D16908.id.diff
Aug 21 2025, 2:39 AM
F18238857: D16908.diff
Aug 20 2025, 10:57 PM
Subscribers
None

Details

Summary

Fixes T11902.

  • Periods now work in short names.
  • If you try to name something ".git", no dice.
Test Plan
  • Tried to name something "quack.git", was politely rejected.
  • Named something "quack.notgit", and it worked fine.
  • Cloned Mercurial and Git repositories over SSH with ".git" and non-".git" variants without hitting any issues.

Diff Detail

Repository
rP Phabricator
Branch
deambig1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14592
Build 19047: Run Core Tests
Build 19046: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't let users pick "whatever.git" as a repository short name, make "." work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2016, 11:46 PM
src/applications/repository/storage/PhabricatorRepository.php
596–597

I couldn't figure out what this was talking about after some probing, so I think we're fine. SSH clones with Mercurial definitely work. Possibly we haven't seen the end of this.

This revision was automatically updated to reflect the committed changes.