Page MenuHomePhabricator

Don't let users pick "whatever.git" as a repository short name, make "." work

Authored by epriestley on Nov 21 2016, 11:46 PM.
Referenced Files
Unknown Object (File)
Sat, Aug 6, 2:50 PM
Unknown Object (File)
Thu, Aug 4, 8:56 AM
Unknown Object (File)
Wed, Jul 27, 2:57 AM
Unknown Object (File)
Wed, Jul 20, 4:14 PM
Unknown Object (File)
Mon, Jul 11, 5:13 AM
Unknown Object (File)
Jul 8 2022, 9:57 PM
Unknown Object (File)
Jul 3 2022, 5:41 PM
Unknown Object (File)
Jul 3 2022, 5:40 PM



Fixes T11902.

  • Periods now work in short names.
  • If you try to name something ".git", no dice.
Test Plan
  • Tried to name something "quack.git", was politely rejected.
  • Named something "quack.notgit", and it worked fine.
  • Cloned Mercurial and Git repositories over SSH with ".git" and non-".git" variants without hitting any issues.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't let users pick "whatever.git" as a repository short name, make "." work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2016, 11:46 PM

I couldn't figure out what this was talking about after some probing, so I think we're fine. SSH clones with Mercurial definitely work. Possibly we haven't seen the end of this.

This revision was automatically updated to reflect the committed changes.