Page MenuHomePhabricator

Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks
ClosedPublic

Authored by epriestley on Nov 18 2016, 10:07 PM.
Tags
None
Referenced Files
F12841410: D16900.id40686.diff
Thu, Mar 28, 9:11 PM
F12841408: D16900.id40685.diff
Thu, Mar 28, 9:11 PM
F12840888: D16900.id.diff
Thu, Mar 28, 8:50 PM
F12840327: D16900.diff
Thu, Mar 28, 8:22 PM
F12818981: D16900.id.diff
Thu, Mar 28, 5:17 AM
F12816923: D16900.id.diff
Thu, Mar 28, 3:58 AM
F12815587: D16900.id40686.diff
Thu, Mar 28, 3:01 AM
F12815586: D16900.id40685.diff
Thu, Mar 28, 3:01 AM
Subscribers
None

Details

Summary

Ref T8345. See T8345#201048 for discussion.

This rule (don't show mentions of or from restricted objects) is more consistent with how we render mentions in the timeline and I think generally a better behavior.

Test Plan
  • Mentioned a task on a public task and a private task.
  • Privileged user (foreground) sees both.
  • Public user (background) sees only the public mention.

Screen Shot 2016-11-18 at 2.04.06 PM.png (589×932 px, 115 KB)

Diff Detail

Repository
rP Phabricator
Branch
mention1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14576
Build 19021: Run Core Tests
Build 19020: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.