Page MenuHomePhabricator
Differential D16873

Add Hero Image to Phame Post
ClosedPublic
Actions

Authored by chad on Nov 15 2016, 9:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Thu, Dec 12, 12:12 AM
Unknown Object (File)
Mon, Dec 9, 3:42 PM
Unknown Object (File)
Thu, Nov 28, 1:12 AM
Unknown Object (File)
Nov 9 2024, 12:38 PM
Unknown Object (File)
Nov 9 2024, 12:38 PM
Unknown Object (File)
Nov 9 2024, 12:38 PM
Unknown Object (File)
Nov 5 2024, 11:38 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPce0cb115ca2a: Add Hero Image to Phame Post
Summary

Adds a headerimage and lets you set it on posts for added reverence. Is that a word?

Test Plan

Add an image, see an image.

pasted_file (806×997 px, 101 KB)

Diff Detail

Repository
rP Phabricator
Branch
phame-post-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14513
Build 18926: Run Core Tests
Build 18925: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40624.Nov 15 2016, 9:22 PM
chad retitled this revision from to Add Hero Image to Phame Post.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 15 2016, 9:22 PM
chad edited the test plan for this revision. (Show Details)Nov 15 2016, 9:23 PM
epriestley edited edge metadata.Nov 15 2016, 9:44 PM

Spoooooky!~

epriestley accepted this revision.Nov 15 2016, 9:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 9:44 PM
Closed by commit rPce0cb115ca2a: Add Hero Image to Phame Post (authored by chad, committed by chad). · Explain WhyNov 15 2016, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
2 lines
applications/
phame/
application/
1 line
controller/
1 line
post/
136 lines
41 lines
editor/
7 lines
query/
29 lines
storage/
16 lines
15 lines

Diff 40624

View Options

resources/sql/autopatches/20161115.phamepost.02.header.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostHeaderPictureController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/query/PhamePostQuery.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
Phabricator · Built by Phacility