Differential D16863

Don't send Phurl mail to the URL object itself
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 5:01 PM.

Details

Reviewers

chad

Maniphest Tasks

T11868: Phurl URLs send email to themselves (???)

Commits

rP508d86aab6cf: Don't send Phurl mail to the URL object itself

Summary

Fixes T11868. This is silly and does not make sense.

Test Plan

Edited a Phurl URL, verified mail only went to me, not to the object itself.

Diff Detail

Repository

rP Phabricator

Branch

phurl1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14493
Build 18896: Run Core Tests
Build 18895: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40603.Nov 15 2016, 5:01 PM

epriestley retitled this revision from to Don't send Phurl mail to the URL object itself.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11868: Phurl URLs send email to themselves (???).

chad accepted this revision.Nov 15 2016, 5:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 5:05 PM

Closed by commit rP508d86aab6cf: Don't send Phurl mail to the URL object itself (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

editor/

PhabricatorPhurlURLEditor.php

4 lines

Diff 40603

View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Don't send Phurl mail to the URL object itselfClosedPublicActions