Page MenuHomePhabricator
Differential D16855

Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode
ClosedPublic
Actions

Authored by epriestley on Nov 14 2016, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:29 AM
Unknown Object (File)
Mon, Apr 8, 7:57 AM
Unknown Object (File)
Sat, Apr 6, 2:58 PM
Unknown Object (File)
Wed, Apr 3, 6:48 AM
Unknown Object (File)
Mon, Apr 1, 11:12 AM
Unknown Object (File)
Mon, Apr 1, 3:48 AM
Unknown Object (File)
Sun, Mar 31, 10:55 PM
Unknown Object (File)
Sun, Mar 31, 8:44 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11818: Phacility `notify` tier is pooled, but tries to load database configuration on restart
Commits
rPfc71a7e92dc2: (stable) Discard stdout/stderr from the aphlict subprocess when running in…
rP7165e4da90a1: Discard stdout/stderr from the aphlict subprocess when running in daemon…
Summary

Fixes T11818. We don't discard output, so once we read more than 2GB of output we'll exceed the maximum size of a string in an internal buffer.

Instead, configure the future so output is discarded.

Test Plan

Added logging to libphutil/, saw internal buffer grow steadily before this change and stay constant at 0 after this change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40586.Nov 14 2016, 12:40 AM
epriestley retitled this revision from to Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11818: Phacility `notify` tier is pooled, but tries to load database configuration on restart.
chad accepted this revision.Nov 14 2016, 12:43 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 14 2016, 12:43 AM
Closed by commit rP7165e4da90a1: Discard stdout/stderr from the aphlict subprocess when running in daemon… (authored by epriestley, committed by epriestley). · Explain WhyNov 14 2016, 12:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
8 lines

Diff 40588

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
Phabricator · Built by Phacility