Page MenuHomePhabricator

Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode
ClosedPublic

Authored by epriestley on Nov 14 2016, 12:40 AM.

Details

Summary

Fixes T11818. We don't discard output, so once we read more than 2GB of output we'll exceed the maximum size of a string in an internal buffer.

Instead, configure the future so output is discarded.

Test Plan

Added logging to libphutil/, saw internal buffer grow steadily before this change and stay constant at 0 after this change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 14 2016, 12:43 AM
This revision was automatically updated to reflect the committed changes.