Page MenuHomePhabricator

Exempt some more puncutation characters from diff smoothing in prose diffs
ClosedPublic

Authored by epriestley on Nov 13 2016, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 4, 6:03 PM
Unknown Object (File)
Tue, Oct 4, 5:03 PM
Unknown Object (File)
Tue, Oct 4, 4:50 PM
Unknown Object (File)
Tue, Sep 20, 5:23 AM
Unknown Object (File)
Sat, Sep 17, 5:26 AM
Unknown Object (File)
Sun, Sep 11, 9:18 AM
Unknown Object (File)
Wed, Sep 7, 3:37 PM
Unknown Object (File)
Aug 15 2022, 11:56 AM
Subscribers
None

Details

Summary

Ref T7643. We intentionally smooth diffs, because an edit which changes "The cat ran past." to "The boar ran past." is easier to read if it looks like this:

The (- cat)(+ boar) ran past.

...than if it looks like this:

The (- c)(+ bo)a(-t)(+r) ran past.

However, this rule currently gives us slightly-too-large word diffs for "words" that contain some punctuation symbols, like ] and ). Include these as layout symbols to generate slightly better diffs.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Exempt some more puncutation characters from diff smoothing in prose diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 13 2016, 10:10 PM
This revision was automatically updated to reflect the committed changes.