Page MenuHomePhabricator
Differential D16844

Rebuild lightbox styles
ClosedPublic
Actions

Authored by chad on Nov 12 2016, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 2:31 PM
Unknown Object (File)
Tue, Dec 3, 10:19 AM
Unknown Object (File)
Thu, Nov 28, 1:11 AM
Unknown Object (File)
Oct 30 2024, 11:15 PM
Unknown Object (File)
Oct 29 2024, 7:17 PM
Unknown Object (File)
Oct 28 2024, 3:52 AM
Unknown Object (File)
Oct 15 2024, 6:54 PM
Unknown Object (File)
Oct 12 2024, 2:45 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPebecbeed4237: Rebuild lightbox styles
Summary

Simpler, lighter background and UI for lightbox. Removes images, uses font icons, buttons.

Test Plan

Lots of lightboxing.

Screen Shot 2016-11-11 at 9.19.54 PM.png (2×2 px, 413 KB)

Diff Detail

Repository
rP Phabricator
Branch
lightbox-attachment (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14454
Build 18839: Run Core Tests
Build 18838: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40561.Nov 12 2016, 5:17 AM
chad retitled this revision from to Rebuild lightbox styles.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 12 2016, 5:17 AM
chad edited the test plan for this revision. (Show Details)Nov 12 2016, 5:20 AM
epriestley accepted this revision.Nov 12 2016, 2:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2016, 2:17 PM
Closed by commit rPebecbeed4237: Rebuild lightbox styles (authored by chad, committed by chad). · Explain WhyNov 12 2016, 3:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40561

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/aphront/lightbox-attachment.css

Loading...
View Options

webroot/rsrc/image/icon/lightbox/close-2.png

Loading...
View Options

webroot/rsrc/image/icon/lightbox/close-hover-2.png

Loading...
View Options

webroot/rsrc/image/icon/lightbox/left-arrow-2.png

Loading...
View Options

webroot/rsrc/image/icon/lightbox/left-arrow-hover-2.png

Loading...
View Options

webroot/rsrc/image/icon/lightbox/right-arrow-2.png

Loading...
View Options

webroot/rsrc/image/icon/lightbox/right-arrow-hover-2.png

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility