Page MenuHomePhabricator
Differential D16841

Fix some policy CSS
ClosedPublic
Actions

Authored by epriestley on Nov 11 2016, 9:31 PM.
Tags
None
Referenced Files
F19088918: D16841.id.diff
Wed, Dec 3, 5:36 AM
F18863554: D16841.diff
Nov 3 2025, 12:06 AM
F18855406: D16841.id.diff
Nov 1 2025, 5:12 AM
F18773737: D16841.diff
Oct 9 2025, 12:16 PM
F18735118: D16841.id.diff
Sep 30 2025, 11:42 PM
F18658882: D16841.id40554.diff
Sep 23 2025, 8:53 AM
F18598476: D16841.id.diff
Sep 13 2025, 5:08 AM
F18592613: D16841.diff
Sep 12 2025, 12:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project
Commits
rP4c540fb01b9a: Fix some policy CSS
Summary

Ref T11853. My CSS change for the more enormous policy dialog was a little too broad, and affected the "You shall not pass!" dialog too.

Narrow the scope of the CSS rules.

Also add a missing "." that I caught.

Test Plan
  • Looked at policy exception dialogs.
  • Looked at policy explanation dialogs.
  • Looked at the end of that sentence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40554.Nov 11 2016, 9:31 PM
epriestley retitled this revision from to Fix some policy CSS.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.
Herald edited edge metadata. · View Herald TranscriptNov 11 2016, 9:31 PM
chad accepted this revision.Nov 11 2016, 9:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 11 2016, 9:38 PM
Closed by commit rP4c540fb01b9a: Fix some policy CSS (authored by epriestley, committed by epriestley). · Explain WhyNov 11 2016, 9:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
policy/
controller/
2 lines
project/
controller/
2 lines
webroot/
rsrc/
css/
aphront/
2 lines

Diff 40558

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectSubprojectWarningController.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
Phabricator · Built by Phacility