Clean up fullscreen remarkup UI
ClosedPublic
Actions

Authored by chad on Nov 10 2016, 6:10 AM.

Tags

None

Referenced Files

	F14352807: D16836.diff
	Thu, Dec 19, 2:49 PM

	Unknown Object (File)
	Tue, Dec 10, 3:44 PM

	Unknown Object (File)
	Sun, Dec 8, 1:54 AM

	Unknown Object (File)
	Sun, Nov 24, 4:46 PM

	Unknown Object (File)
	Thu, Nov 21, 3:39 AM

	Unknown Object (File)
	Nov 17 2024, 12:24 AM

	Unknown Object (File)
	Nov 10 2024, 3:38 PM

	Unknown Object (File)
	Oct 21 2024, 2:33 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP6dc94fc10a3b: Clean up fullscreen remarkup UI

Summary

Some aftermath fallout from rebuilding the comment box.

Test Plan

Go fullscreen, pop back out.

Diff Detail

Repository

rP Phabricator

Branch

fullscreen-remarkup (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14435
Build 18811: Run Core Tests
Build 18810: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40544.Nov 10 2016, 6:10 AM

chad retitled this revision from to Clean up fullscreen remarkup UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 10 2016, 6:10 AM

epriestley accepted this revision.Nov 10 2016, 2:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 10 2016, 2:02 PM

Closed by commit rP6dc94fc10a3b: Clean up fullscreen remarkup UI (authored by chad, committed by chad). · Explain WhyNov 10 2016, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

12 lines

Diff 40544

View Options

resources/celerity/map.php