Page MenuHomePhabricator
Differential D16831

Remove empty implementations of `describeAutomaticCapabilities()`
ClosedPublic
Actions

Authored by epriestley on Nov 9 2016, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:55 AM
Unknown Object (File)
Mon, Apr 22, 9:05 PM
Unknown Object (File)
Mon, Apr 22, 9:05 PM
Unknown Object (File)
Mon, Apr 22, 9:04 PM
Unknown Object (File)
Thu, Apr 11, 10:27 AM
Unknown Object (File)
Wed, Apr 10, 9:20 PM
Unknown Object (File)
Wed, Apr 10, 7:42 PM
Unknown Object (File)
Wed, Apr 10, 6:18 PM
View All Files
Subscribers
hach-que
Restricted Owners Package

Details

Reviewers
chad
Commits
rP706c21375e8f: Remove empty implementations of `describeAutomaticCapabilities()`
Summary

This has been replaced by PolicyCodex after D16830. Also:

  • Rebuild Celerity map to fix grumpy unit test.
  • Fix one issue on the policy exception workflow to accommodate the new code.
Test Plan
  • arc unit --everything
  • Viewed policy explanations.
  • Viewed policy errors.

Diff Detail

Repository
rP Phabricator
Branch
policy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14424
Build 18795: Run Core Tests
Build 18794: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40534.Nov 9 2016, 11:23 PM
epriestley retitled this revision from to Remove empty implementations of `describeAutomaticCapabilities()`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Owners added a subscriber: Restricted Owners Package.Nov 9 2016, 11:23 PM
Herald added a subscriber: hach-que. · View Herald TranscriptNov 9 2016, 11:23 PM
chad accepted this revision.Nov 9 2016, 11:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 11:24 PM
Closed by commit rP706c21375e8f: Remove empty implementations of `describeAutomaticCapabilities()` (authored by epriestley, committed by epriestley). · Explain WhyNov 9 2016, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
almanac/
storage/
4 lines
4 lines
4 lines
4 lines
auth/
storage/
4 lines
4 lines
badges/
storage/
4 lines
4 lines
base/
4 lines
calendar/
storage/
3 lines
5 lines
3 lines
4 lines
4 lines
chatlog/
storage/
4 lines
4 lines
conduit/
method/
4 lines
storage/
4 lines
config/
storage/
4 lines
countdown/
storage/
4 lines
daemon/
storage/
4 lines
dashboard/
storage/
4 lines
4 lines
differential/
storage/
4 lines
4 lines
diviner/
storage/
4 lines
doorkeeper/
storage/
4 lines
drydock/
storage/
4 lines
feed/
story/
5 lines
files/
storage/
5 lines
legalpad/
storage/
4 lines
macro/
storage/
4 lines
nuance/
storage/
4 lines
4 lines
4 lines
4 lines
oauthserver/
storage/
4 lines
packages/
storage/
4 lines
4 lines
4 lines
passphrase/
storage/
4 lines
phlux/
storage/
4 lines
pholio/
storage/
4 lines
phortune/
storage/
4 lines
phragment/
storage/
4 lines
policy/
__tests__/
4 lines
controller/
41 lines
filter/
11 lines
storage/
52 lines
project/
storage/
4 lines
releeph/
storage/
5 lines
repository/
storage/
5 lines
4 lines
4 lines
4 lines
4 lines
search/
storage/
5 lines
4 lines
settings/
storage/
5 lines
spaces/
storage/
5 lines
tokens/
storage/
4 lines
transactions/
editengine/
3 lines
storage/
5 lines
infrastructure/
daemon/
workers/
storage/
4 lines

Diff 40534

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/almanac/storage/AlmanacDevice.php

Loading...
View Options

src/applications/almanac/storage/AlmanacNamespace.php

Loading...
View Options

src/applications/almanac/storage/AlmanacNetwork.php

Loading...
View Options

src/applications/almanac/storage/AlmanacService.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthTemporaryToken.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesAward.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarExport.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarImport.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarImportLog.php

Loading...
View Options

src/applications/chatlog/storage/PhabricatorChatLogChannel.php

Loading...
View Options

src/applications/chatlog/storage/PhabricatorChatLogEvent.php

Loading...
View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php

Loading...
View Options

src/applications/config/storage/PhabricatorConfigEntry.php

Loading...
View Options

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...
View Options

src/applications/daemon/storage/PhabricatorDaemonLog.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveBook.php

Loading...
View Options

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php

Loading...
View Options

src/applications/drydock/storage/DrydockBlueprint.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStory.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileChunk.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocumentSignature.php

Loading...
View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...
View Options

src/applications/nuance/storage/NuanceImportCursorData.php

Loading...
View Options

src/applications/nuance/storage/NuanceItemCommand.php

Loading...
View Options

src/applications/nuance/storage/NuanceQueue.php

Loading...
View Options

src/applications/nuance/storage/NuanceSource.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

Loading...
View Options

src/applications/packages/storage/PhabricatorPackagesPackage.php

Loading...
View Options

src/applications/packages/storage/PhabricatorPackagesPublisher.php

Loading...
View Options

src/applications/packages/storage/PhabricatorPackagesVersion.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/phlux/storage/PhluxVariable.php

Loading...
View Options

src/applications/pholio/storage/PholioImage.php

Loading...
View Options

src/applications/phortune/storage/PhortuneProduct.php

Loading...
View Options

src/applications/phragment/storage/PhragmentFragment.php

Loading...
View Options

src/applications/policy/__tests__/PhabricatorPolicyTestObject.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...
View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumnPosition.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommitHint.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryGitLFSRef.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryOldRef.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
View Options

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...
View Options

src/applications/search/storage/PhabricatorSavedQuery.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

Loading...
View Options

src/applications/tokens/storage/PhabricatorToken.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Loading...
Phabricator · Built by Phacility